[Phamm] [PATCH] phamm-0.5.15: Use TEXTAREA instead of confusing checkbox to unset multiple valued attribute

[Alessandro De Zorzi]

kabe a sra-tohoku.co.jp wrote:
> My previous patch sent on 2009-02-04 screwed the
> vacationForward <subordinateddelete> interface, so this new patch will
> totally abolish that check-to-delete checkbox and use only TEXTAREA.
> Please discard the "[PATCH] phamm-0.5.15: fix interface for the confusing checkbox to unset multiple valued attribute" patch.
>   
Your works is appreciated. I am trying your patch.

As you put in evidence in previews messages Phamm must works
witch text-browser and without js support. Your patch in lib/xhtml.php
seems make impossible delete vacationForward value with js disabled.

I agree interface with check-to-delete box is not intuitive and we should to
improve it. Many other features suggested in these years, for example, a
simple
way to choose address from e-mail address from the same domain. Address
input validation, show all destinations in table view (at this time only
the first destination
showed...)

Take in mind that functions in lib/xhtml.php works  for general purpose
and not for mail plugin only. Your patch improve alias view and alias
destinations
modification (I agree). But consider other multi-values in others
plug-in or future
plugins.

cheers
Alessandro De Zorzi

*** 923,929 ****

      if ($_SESSION["login"]["level"] >= $minAuthLevel)
      {
!   $js_string = ($field == 'vacationactive' ?
'onchange="subordinatedelete.checked=true;"' : '');

    $tag .= '<select name="'.$table.'['.$field.']" '.$js_string.'>';

--- 945,951 ----

      if ($_SESSION["login"]["level"] >= $minAuthLevel)
      {
!   $js_string = ($field == 'vacationactive' ?
'onchange="subordinatedelete.value=\'\';"' : '');

    $tag .= '<select name="'.$table.'['.$field.']" '.$js_string.'>